-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][Connector-V2] Add Huawei Cloud OBS connector #4578
Conversation
Good pull request, let's waiting CI |
The dependency of @TyrantLucifer How should this be handled? |
You can find solution in |
@@ -0,0 +1,260 @@ | |||
# ObsFile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussion in the community, we have optimized the format requirements of the document, which you can refer to:https://github.com/apache/incubator-seatunnel/issues/4544
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
Please add e2e testcase and make junit @disabled |
@TyrantLucifer @EricJoy2048 @hailin0 Is there anything else I need to do ? |
@TyrantLucifer @hailin0 @EricJoy2048 @jbonofre Asking for Help!. Are there any end-to-end test examples for file storage cloud services such as obs, oss, and s3? Because it involves sensitive information such as ak and sk. And cloud services do not necessarily have relevant docker images that can be used for Mock testing. |
Hi @kim-up , you can add a e2e test case and run it in your local env, before submit codes you should add annotation to disabled it and remove sensitive information from config file. Finally offer the snapshot image in this pull request. You can refer to |
Get it. |
…tor-seatunnel into connector-file-obs
Docs & e2e have add. Start the workflow? @TyrantLucifer @EricJoy2048 @hailin0 |
Approved, let's waiting CI/CD, BTW could you please offer some snapshots of this connector? |
What is |
Local Test ImagesCsv Testfake_to_obs_csv
Resultobs_csv_projection_to_assert
Result |
Local Test ImagesExcel Testfake_to_obs_excel
Resultobs_excel_projection_to_assert
Result |
Local Test ImagesJson Testfake_to_obs_file_json
Resultobs_file_json_to_assert
Result |
Local Test ImagesOrc Testfake_to_obs_file_orc
Resultobs_file_orc_projection_to_assert
Result |
Local Test ImagesParquet Testfake_to_obs_file_parquet
Resultobs_file_parquet_projection_to_assert
Result |
Local Test ImagesText Testfake_to_obs_file_text
Resultobs_file_text_projection_to_assert
Result |
@TyrantLucifer Did you mean the test screenshot provided above? |
…tor-seatunnel into connector-file-obs # Conflicts: # release-note.md
@kim-up Please use mvn spotless:apply to format the code. |
Done. Fixed by merging |
Hi, @kim-up |
#4577
Purpose of this pull request
Check list
New License Guide
release-note
.